Change in ovirt-engine[master]: core: SuperUser can not use virtio serial console

tjelinek at redhat.com tjelinek at redhat.com
Tue May 24 08:06:04 UTC 2016


Tomas Jelinek has submitted this change and it was merged.

Change subject: core: SuperUser can not use virtio serial console
......................................................................


core: SuperUser can not use virtio serial console

The problem was that the query returning the list of VMs where the user has the
CONNECT_TO_SERIAL_CONSOLE used the GetAllFromVmsForUserAndActionGroup stored
procedure.

This stored procedure was based on the user_vm_permissions_view which did not
contain the admin roles.

Fixed by creating a new view vm_permissions_view which contains both the admin
and user roles.

Change-Id: Ia5f07ab7fd89714b4ab3709639c6e15dfdba1d8e
Bug-Url: https://bugzilla.redhat.com/1320343
Signed-off-by: Tomas Jelinek <tjelinek at redhat.com>
---
M packaging/dbscripts/create_views.sql
M packaging/dbscripts/vms_sp.sql
2 files changed, 31 insertions(+), 17 deletions(-)

Approvals:
  Tomas Jelinek: Verified
  Eli Mesika: Looks good to me, but someone else must approve
  Jenkins CI: Passed CI tests
  Arik Hadas: Looks good to me, approved



-- 
To view, visit https://gerrit.ovirt.org/57737
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ia5f07ab7fd89714b4ab3709639c6e15dfdba1d8e
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Tomas Jelinek <tjelinek at redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas at redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tomas Jelinek <tjelinek at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>



More information about the Engine-commits mailing list