Change in ovirt-engine[master]: core: CommandBase - endAction() lock release

laravot at redhat.com laravot at redhat.com
Wed May 25 12:22:46 UTC 2016


Liron Aravot has submitted this change and it was merged.

Change subject: core: CommandBase - endAction() lock release
......................................................................


core: CommandBase - endAction() lock release

When ending command action the commands locks are freed on
endActionInTransactionScope() which is wrong because the
transaction should  be committed before the lock is released.
additionally, currently there is a duplicate call which is unneeded.

Change-Id: Ia1405b6010cfebc5cdbe4ac8c87822ea6fc0fd72
Signed-off-by: Liron Aravot <laravot at redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java
1 file changed, 3 insertions(+), 2 deletions(-)

Approvals:
  Moti Asayag: Looks good to me, approved
  Liron Aravot: Verified; Passed CI tests



-- 
To view, visit https://gerrit.ovirt.org/57688
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ia1405b6010cfebc5cdbe4ac8c87822ea6fc0fd72
Gerrit-PatchSet: 9
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Liron Aravot <laravot at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Liron Aravot <laravot at redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag at redhat.com>
Gerrit-Reviewer: Ravi Nori <rnori at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>



More information about the Engine-commits mailing list