Change in ovirt-engine[ovirt-engine-3.6.7]: core: Create vm_templates_view without other entity types
tnisan at redhat.com
tnisan at redhat.com
Thu May 26 08:31:23 UTC 2016
Tal Nisan has submitted this change and it was merged.
Change subject: core: Create vm_templates_view without other entity types
......................................................................
core: Create vm_templates_view without other entity types
The search query used currently for Templates view looks over
vm_templates_view that contains several different entity types and then
filters templates out of the result that was returned from SQL query.
But this works badly with limited queries - the query that is limited
to return one page of results (for example, 100 items) may return less.
>From Frontend point of view, the page that is not full should be the
last one.
To fix this, a new view must be created containing only template
entities. The post-filtering will not be needed and the query will
always return a full page of results for all pages except the last one.
Change-Id: I244c9a22fd3d8bd9e0b3ac2ebea717740fc030d9
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1338816
Signed-off-by: Shmuel Melamud <smelamud at redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/SearchQuery.java
M packaging/dbscripts/create_views.sql
M packaging/dbscripts/vm_templates_sp.sql
M packaging/dbscripts/vms_sp.sql
4 files changed, 71 insertions(+), 73 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Shmuel Leib Melamud: Verified
Arik Hadas: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/58080
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I244c9a22fd3d8bd9e0b3ac2ebea717740fc030d9
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.6.7
Gerrit-Owner: Shmuel Leib Melamud <smelamud at redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas at redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Shmuel Leib Melamud <smelamud at redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
More information about the Engine-commits
mailing list