Change in ovirt-engine[master]: core: GetAllAttachableDisksForVmQuery branching

amureini at redhat.com amureini at redhat.com
Thu May 26 13:58:39 UTC 2016


Allon Mureinik has submitted this change and it was merged.

Change subject: core: GetAllAttachableDisksForVmQuery branching
......................................................................


core: GetAllAttachableDisksForVmQuery branching

Removed a useless if from
GetAllAttachableDisksForVmQuery#executeQueryCommand. Since entering and
not entering the if has the same effect, it's useless, and can safely be
removed.

This patch fixes Coverity issue 1355578.

Change-Id: If6afa979b5fb4375bfa344ee8711b1a155e2d848
Signed-off-by: Allon Mureinik <amureini at redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/GetAllAttachableDisksForVmQuery.java
1 file changed, 2 insertions(+), 11 deletions(-)

Approvals:
  Tal Nisan: Looks good to me, approved
  Jenkins CI: Passed CI tests
  Allon Mureinik: Verified



-- 
To view, visit https://gerrit.ovirt.org/58138
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: If6afa979b5fb4375bfa344ee8711b1a155e2d848
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>



More information about the Engine-commits mailing list