Change in ovirt-engine[ovirt-engine-4.0]: core: CommandBase - endAction() lock release

tnisan at redhat.com tnisan at redhat.com
Sun May 29 07:39:26 UTC 2016


Tal Nisan has submitted this change and it was merged.

Change subject: core: CommandBase - endAction() lock release
......................................................................


core: CommandBase - endAction() lock release

When ending command action the commands locks are freed on
endActionInTransactionScope() which is wrong because the
transaction should  be committed before the lock is released.
additionally, currently there is a duplicate call which is unneeded.

Change-Id: Ia1405b6010cfebc5cdbe4ac8c87822ea6fc0fd72
Signed-off-by: Liron Aravot <laravot at redhat.com>
Bug-Url: https://bugzilla.redhat.com/1339308
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java
1 file changed, 3 insertions(+), 2 deletions(-)

Approvals:
  Jakub Niedermertl: Verified
  Jenkins CI: Passed CI tests
  Moti Asayag: Looks good to me, approved



-- 
To view, visit https://gerrit.ovirt.org/58174
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ia1405b6010cfebc5cdbe4ac8c87822ea6fc0fd72
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-4.0
Gerrit-Owner: Jakub Niedermertl <jniederm at redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas at redhat.com>
Gerrit-Reviewer: Jakub Niedermertl <jniederm at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Liron Aravot <laravot at redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag at redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>



More information about the Engine-commits mailing list