Change in ovirt-engine[ovirt-engine-4.0]: webadmin: Null check before model cleanup

Code Review gerrit at ovirt.org
Tue Nov 1 05:32:51 UTC 2016


>From Tal Nisan <tnisan at redhat.com>:

Tal Nisan has submitted this change and it was merged.

Change subject: webadmin: Null check before model cleanup
......................................................................


webadmin: Null check before model cleanup

Patch gerrit.ovirt.org/63708 introduced improved model cleanup yet in
cases where the model is already null due to a missing null check a UI
exception will be thrown (for instance when closing a dialog with ESC)

Bug-Url: https://bugzilla.redhat.com/1379312
Bug-Url: https://bugzilla.redhat.com/1389998
Change-Id: I89b94e175352a25019bfcabf1af70ea9a615af83
Signed-off-by: Tal Nisan <tnisan at redhat.com>
Signed-off-by: Greg Sheremeta <gshereme at redhat.com>
---
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/presenter/AbstractModelBoundPopupPresenterWidget.java
1 file changed, 5 insertions(+), 2 deletions(-)

Approvals:
  Alexander Wels: Looks good to me, approved
  Jenkins CI: Passed CI tests
  Greg Sheremeta: Verified



-- 
To view, visit https://gerrit.ovirt.org/65917
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I89b94e175352a25019bfcabf1af70ea9a615af83
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-4.0
Gerrit-Owner: Greg Sheremeta <gshereme at redhat.com>
Gerrit-Reviewer: Alexander Wels <awels at redhat.com>
Gerrit-Reviewer: Greg Sheremeta <gshereme at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Oved Ourfali <oourfali at redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vszocs at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>



More information about the Engine-commits mailing list