Change in ovirt-engine-sdk-ruby[sdk_4.0]: Clarify the units of `provisioned_size`
Code Review
gerrit at ovirt.org
Fri Nov 4 18:59:25 UTC 2016
>From Juan Hernandez <juan.hernandez at redhat.com>:
Juan Hernandez has submitted this change and it was merged.
Change subject: Clarify the units of `provisioned_size`
......................................................................
Clarify the units of `provisioned_size`
This patch changes the example to add a VM disk so that it is clearer
that size of a disk has to be specified in bytes. It also changes the
example to use a more realistic size, 10 GiB, as it currently the size
is 1 MiB, which isn't realistic.
Change-Id: If21816ca1b180883bb799b32a2fd5857e7e25cd2
Signed-off-by: Juan Hernandez <juan.hernandez at redhat.com>
(cherry picked from commit 8e73bf7af2c9fea227ec8f9e4b84baebd5ea620f)
---
M sdk/examples/add_floating_disk.rb
M sdk/examples/add_vm_disk.rb
2 files changed, 9 insertions(+), 4 deletions(-)
Approvals:
Juan Hernandez: Verified; Looks good to me, approved; Passed CI tests
--
To view, visit https://gerrit.ovirt.org/66097
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: If21816ca1b180883bb799b32a2fd5857e7e25cd2
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine-sdk-ruby
Gerrit-Branch: sdk_4.0
Gerrit-Owner: Juan Hernandez <juan.hernandez at redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernandez at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
More information about the Engine-commits
mailing list