Change in ovirt-engine[master]: core: BackendClusterNetworksResource#getNetworks params

Code Review gerrit at ovirt.org
Mon Nov 7 10:51:05 UTC 2016


>From Juan Hernandez <juan.hernandez at redhat.com>:

Juan Hernandez has submitted this change and it was merged.

Change subject: core: BackendClusterNetworksResource#getNetworks params
......................................................................


core: BackendClusterNetworksResource#getNetworks params

getNetworks(String) is only ever called with the clusterId member,
making having this parameter redundant and confusing.
This patch cleans up the code by removing that parameter and using the
data member directly.

Change-Id: I8b67ff16e6fcd5035bf6ac82c1411c56be851859
Signed-off-by: Allon Mureinik <amureini at redhat.com>
---
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendClusterNetworksResource.java
1 file changed, 2 insertions(+), 2 deletions(-)

Approvals:
  Juan Hernandez: Looks good to me, approved; Passed CI tests
  Allon Mureinik: Verified



-- 
To view, visit https://gerrit.ovirt.org/66138
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I8b67ff16e6fcd5035bf6ac82c1411c56be851859
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Juan Hernandez <juan.hernandez at redhat.com>
Gerrit-Reviewer: Martin Mucha <mmucha at redhat.com>
Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>



More information about the Engine-commits mailing list