Change in ovirt-engine[ovirt-engine-4.0]: core: remove vm usage related histories from the database
Code Review
gerrit at ovirt.org
Wed Nov 9 09:51:42 UTC 2016
>From Tal Nisan <tnisan at redhat.com>:
Tal Nisan has submitted this change and it was merged.
Change subject: core: remove vm usage related histories from the database
......................................................................
core: remove vm usage related histories from the database
Now that VmStatistics are cached in VmManager, there is no need
to dump several things they contain to the database. However,
since we currently focus on easy and non-risky things, this patch
addresses specifically the memory/cpu/network usage histories -
these are really redundant being the database as they are only
used by the webadmin that gathers the information using a
(search) query that takes this information from VmManager.
Unfortunately, we can neither drop the whole statistics from the
database nor reduce the frequency of the updates at this stage.
This kind of changes can improve performance on large-scale setups
significantely since they reduce the amount of data dump into the
database substantially.
Change-Id: If72063205907c21d9bd80610a1c1ea1356a9c5e6
Bug-Url: https://bugzilla.redhat.com/1340722
Signed-off-by: Arik Hadas <ahadas at redhat.com>
---
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VmStatisticsDaoImpl.java
M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/VmStatisticsDaoTest.java
M backend/manager/modules/dal/src/test/resources/fixtures.xml
M packaging/dbscripts/create_views.sql
A packaging/dbscripts/upgrade/04_00_0980_remove_vm_related_usage_histories.sql
M packaging/dbscripts/vms_sp.sql
6 files changed, 3 insertions(+), 78 deletions(-)
Approvals:
Shahar Havivi: Looks good to me, approved
Jenkins CI: Passed CI tests
Arik Hadas: Verified
--
To view, visit https://gerrit.ovirt.org/66054
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: If72063205907c21d9bd80610a1c1ea1356a9c5e6
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-4.0
Gerrit-Owner: Arik Hadas <ahadas at redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Maor Lipchuk <mlipchuk at redhat.com>
Gerrit-Reviewer: Shahar Havivi <shavivi at redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
More information about the Engine-commits
mailing list