Change in ovirt-engine[ovirt-engine-4.0]: core: fix the upgrade script that converts memory volumes to...

Code Review gerrit at ovirt.org
Thu Nov 10 09:10:11 UTC 2016


>From Tal Nisan <tnisan at redhat.com>:

Tal Nisan has submitted this change and it was merged.

Change subject: core: fix the upgrade script that converts memory volumes to disks
......................................................................


core: fix the upgrade script that converts memory volumes to disks

This patch fixes yet another problem that was found in the upgrade
script that converts snapshot's memory volumes to disks in the
database. This time the problem is with using 'NOT IN <set>' where
the set could have NULL values (therefore the fix is to filter the
NULL values from the set).

Change-Id: I48103802395e58afb155a4501e36c256dbf65084
Bug-Url: https://bugzilla.redhat.com/1390254
Signed-off-by: Arik Hadas <ahadas at redhat.com>
---
M packaging/dbscripts/upgrade/04_00_0140_convert_memory_snapshots_to_disks.sql
1 file changed, 1 insertion(+), 0 deletions(-)

Approvals:
  Shahar Havivi: Looks good to me, approved
  Jenkins CI: Passed CI tests
  Allon Mureinik: Looks good to me, but someone else must approve
  Arik Hadas: Verified



-- 
To view, visit https://gerrit.ovirt.org/66313
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I48103802395e58afb155a4501e36c256dbf65084
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-4.0
Gerrit-Owner: Arik Hadas <ahadas at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas at redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Shahar Havivi <shavivi at redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>



More information about the Engine-commits mailing list