Change in ovirt-engine[ovirt-engine-4.0]: core: prevent NPE on unmanaged migrations

Code Review gerrit at ovirt.org
Thu Nov 17 13:55:08 UTC 2016


>From Tal Nisan <tnisan at redhat.com>:

Tal Nisan has submitted this change and it was merged.

Change subject: core: prevent NPE on unmanaged migrations
......................................................................


core: prevent NPE on unmanaged migrations

During migrations that were not initiated by the engine we
do not have the destination host, unfortunately. This patch
prevents the NPE that is then thrown in the hand-over by a
simple null-check. The VM would then be set to MigratingTo
and its runOnVds would be null. Thus, we enhance the VM
analysing with a proper handling for this new state - when
the VM would be detected on the destination host, its
runOnVds will change to point to that host.

Change-Id: Ie11c0eb14318d8ab28f613cbf012879aba4f2ab9
Bug-Url: https://bugzilla.redhat.com/1392903
Signed-off-by: Arik Hadas <ahadas at redhat.com>
---
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/monitoring/VmAnalyzer.java
1 file changed, 15 insertions(+), 4 deletions(-)

Approvals:
  Jenkins CI: Passed CI tests
  Shmuel Leib Melamud: Looks good to me, but someone else must approve
  Michal Skrivanek: Looks good to me, but someone else must approve
  Arik Hadas: Verified; Looks good to me, approved



-- 
To view, visit https://gerrit.ovirt.org/66970
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ie11c0eb14318d8ab28f613cbf012879aba4f2ab9
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-4.0
Gerrit-Owner: Arik Hadas <ahadas at redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek at redhat.com>
Gerrit-Reviewer: Shmuel Leib Melamud <smelamud at redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>



More information about the Engine-commits mailing list