Change in ovirt-engine[ovirt-engine-4.0]: core: Test if autogenerated LSM snapshot can be created prio...
Code Review
gerrit at ovirt.org
Thu Nov 17 14:13:48 UTC 2016
>From Tal Nisan <tnisan at redhat.com>:
Tal Nisan has submitted this change and it was merged.
Change subject: core: Test if autogenerated LSM snapshot can be created prior to running
......................................................................
core: Test if autogenerated LSM snapshot can be created prior to running
Before attempting to run LSM which starts by creating the autogenerated
snapshot, validate the snapshot creation command.
Also since we are running the validation of the snapshot create command
the common validations can be removed from LiveMigrateVmDisksCommand.
The relevant test were also removed after validating that they exist in
CreateAllSnapshotByVmCommandTest
Change-Id: I7454a3bf5e17e9945a612f1f9bfbee15558cd1df
Bug-Url: https://bugzilla.redhat.com/1396108
Signed-off-by: Tal Nisan <tnisan at redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/lsm/LiveMigrateVmDisksCommand.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/lsm/LiveMigrateVmDisksCommandTest.java
2 files changed, 33 insertions(+), 134 deletions(-)
Approvals:
Tal Nisan: Verified
Jenkins CI: Passed CI tests
Allon Mureinik: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/67002
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I7454a3bf5e17e9945a612f1f9bfbee15558cd1df
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-4.0
Gerrit-Owner: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Amit Aviram <aaviram at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
More information about the Engine-commits
mailing list