Change in ovirt-engine[master]: webadmin: Fix FE NPE in Edit Template dialog

Code Review gerrit at ovirt.org
Mon Nov 21 12:56:41 UTC 2016


>From Tomas Jelinek <tjelinek at redhat.com>:

Tomas Jelinek has submitted this change and it was merged.

Change subject: webadmin: Fix FE NPE in Edit Template dialog
......................................................................


webadmin: Fix FE NPE in Edit Template dialog

Problem: initialization of rng device editor required selected cluster.
However it was called independently from the cluster initialization
itself. Thus selected cluster might be required before its
initialization.

Solution: initialization of rng device editor was moved to the callback
of cluster initialization.

Change-Id: I6e82d38f9259bcfd523381e6e0faf48e34add9c3
Problem: initialization of rng device editor requires
Signed-off-by: Jakub Niedermertl <jniederm at redhat.com>
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/TemplateVmModelBehavior.java
1 file changed, 2 insertions(+), 2 deletions(-)

Approvals:
  Tomas Jelinek: Looks good to me, approved
  Jakub Niedermertl: Verified
  Jenkins CI: Passed CI tests



-- 
To view, visit https://gerrit.ovirt.org/66753
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I6e82d38f9259bcfd523381e6e0faf48e34add9c3
Gerrit-PatchSet: 8
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Jakub Niedermertl <jniederm at redhat.com>
Gerrit-Reviewer: Jakub Niedermertl <jniederm at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tomas Jelinek <tjelinek at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>



More information about the Engine-commits mailing list