Change in ovirt-engine[master]: core: Test VdcQueryType constant existence

Code Review gerrit at ovirt.org
Thu Nov 3 17:14:43 UTC 2016


>From Allon Mureinik <amureini at redhat.com>:

Allon Mureinik has submitted this change and it was merged.

Change subject: core: Test VdcQueryType constant existence
......................................................................


core: Test VdcQueryType constant existence

QueryExistenceTest has a test to ensure that any VdcQueryType constant
has a corresponding command class.

This patch adds the reverse test, scanning the relevant packages using
org.reflections.Reflections and verifying that each command class has a
corresponding constant in VdcQueryType.

Change-Id: Icb9fbc1c3215a9e01d27b29e2ac01e092be43aea
Signed-off-by: Allon Mureinik <amureini at redhat.com>
---
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/QueryExistenceTest.java
1 file changed, 5 insertions(+), 0 deletions(-)

Approvals:
  Tal Nisan: Looks good to me, approved
  Jenkins CI: Passed CI tests
  Allon Mureinik: Verified

Objections:
  Tal Nisan: Fails



-- 
To view, visit https://gerrit.ovirt.org/66048
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Icb9fbc1c3215a9e01d27b29e2ac01e092be43aea
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Betak <mbetak at redhat.com>
Gerrit-Reviewer: Martin Peřina <mperina at redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>



More information about the Engine-commits mailing list