Change in ovirt-engine-sdk-java[sdk_4.0]: Clarify the units of `provisioned_size`

Code Review gerrit at ovirt.org
Fri Nov 4 11:31:06 UTC 2016


>From Ondra Machacek <omachace at redhat.com>:

Ondra Machacek has submitted this change and it was merged.

Change subject: Clarify the units of `provisioned_size`
......................................................................


Clarify the units of `provisioned_size`

This patch changes the example to add a VM disk so that it is clearer
that size of a disk has to be specified in bytes. It also changes the
example to use a more realistic size, 10 GiB, as it currently the size
is 1 MiB, which isn't realistic.

Change-Id: Iae61d5ef6a01f59618ed87d2685b5b48400b96ee
Signed-off-by: Juan Hernandez <juan.hernandez at redhat.com>
(cherry picked from commit f049260bf13219bba13041ad389d0444e11d68eb)
---
M sdk/src/test/java/org/ovirt/engine/sdk4/examples/AddFloatingDisk.java
M sdk/src/test/java/org/ovirt/engine/sdk4/examples/AddVmDisk.java
2 files changed, 18 insertions(+), 15 deletions(-)

Approvals:
  Ondra Machacek: Verified; Looks good to me, approved
  Jenkins CI: Passed CI tests



-- 
To view, visit https://gerrit.ovirt.org/66075
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Iae61d5ef6a01f59618ed87d2685b5b48400b96ee
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine-sdk-java
Gerrit-Branch: sdk_4.0
Gerrit-Owner: Ondra Machacek <omachace at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Juan Hernandez <juan.hernandez at redhat.com>
Gerrit-Reviewer: Ondra Machacek <omachace at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>



More information about the Engine-commits mailing list