Change in ovirt-engine[master]: core: Remove GetClusterByClusterIdQuery

[Code Review]

>From Allon Mureinik <amureini at redhat.com>:

Allon Mureinik has submitted this change and it was merged.

Change subject: core: Remove GetClusterByClusterIdQuery
......................................................................


core: Remove GetClusterByClusterIdQuery

GetClusterByClusterIdQuery and GetClusterByIdQuery have the same
functionality (in fact, GetClusterByClusterIdQuery has a potential
security risk by declaring its a user query but not filtering the
results).

This patch removes GetClusterByClusterIdQuery and replaces all its
usages with GetClusterByIdQuery in order to clean up the code and avoid
the potential risk.

Change-Id: Id4de9ed1672b2de7983d29302c31ad99b33b2148
Signed-off-by: Allon Mureinik <amureini at redhat.com>
---
D backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetClusterByClusterIdQuery.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/VdcQueryType.java
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendClusterNetworksResource.java
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendTemplatesResource.java
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendVmsResource.java
M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendClusterNetworkResourceTest.java
M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendClusterNetworksResourceTest.java
M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendTemplatesResourceTest.java
M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendVmsResourceTest.java
9 files changed, 17 insertions(+), 34 deletions(-)

Approvals:
  Tal Nisan: Looks good to me, approved
  Juan Hernandez: Looks good to me, but someone else must approve
  Martin Betak: Looks good to me, but someone else must approve
  Allon Mureinik: Verified; Passed CI tests



-- 
To view, visit https://gerrit.ovirt.org/66140
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Id4de9ed1672b2de7983d29302c31ad99b33b2148
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Juan Hernandez <juan.hernandez at redhat.com>
Gerrit-Reviewer: Martin Betak <mbetak at redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>