Change in ovirt-engine[master]: core: Extract GetAllVmsQueryBase
Code Review
gerrit at ovirt.org
Mon Nov 7 21:33:46 UTC 2016
>From Allon Mureinik <amureini at redhat.com>:
Allon Mureinik has submitted this change and it was merged.
Change subject: core: Extract GetAllVmsQueryBase
......................................................................
core: Extract GetAllVmsQueryBase
Extract a common base class for all the queries that take a list of VMs
and update the guest agent info on them instead of having the code
duplicated.
Change-Id: I074643a9642959fd0baab858ebf7b815171961a9
Signed-off-by: Allon Mureinik <amureini at redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetAllPoolVmsQuery.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetAllVmsForUserAndActionGroupQuery.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetAllVmsForUserQuery.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetAllVmsQuery.java
A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetAllVmsQueryBase.java
5 files changed, 46 insertions(+), 38 deletions(-)
Approvals:
Tal Nisan: Looks good to me, approved
Jenkins CI: Passed CI tests
Martin Betak: Looks good to me, but someone else must approve
Allon Mureinik: Verified
--
To view, visit https://gerrit.ovirt.org/66175
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I074643a9642959fd0baab858ebf7b815171961a9
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Betak <mbetak at redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
More information about the Engine-commits
mailing list