Change in ovirt-engine[master]: core: RegisterVdsQueryTest#injectorRule

Code Review gerrit at ovirt.org
Mon Nov 7 21:33:46 UTC 2016


>From Allon Mureinik <amureini at redhat.com>:

Allon Mureinik has submitted this change and it was merged.

Change subject: core: RegisterVdsQueryTest#injectorRule
......................................................................


core: RegisterVdsQueryTest#injectorRule

Convert the InjectorRule to a ClassRule. This achieves two things:

1. It's safer, as the ClassRule is guaranteed to run before any
   @Before method.
2. It's a tad faster, as the rule is only initialized once instead of
   once per test.

Change-Id: I504ca94b5f6bb08151d33a1e817988577725973a
Signed-off-by: Allon Mureinik <amureini at redhat.com>
---
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/hostdeploy/RegisterVdsQueryTest.java
1 file changed, 3 insertions(+), 3 deletions(-)

Approvals:
  Tal Nisan: Looks good to me, approved
  Jenkins CI: Passed CI tests
  Martin Betak: Looks good to me, but someone else must approve
  Allon Mureinik: Verified



-- 
To view, visit https://gerrit.ovirt.org/66171
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I504ca94b5f6bb08151d33a1e817988577725973a
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Betak <mbetak at redhat.com>
Gerrit-Reviewer: Martin Peřina <mperina at redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>



More information about the Engine-commits mailing list