Change in gerrit-admin[master]: Fix 'NoneType' in is_draft argument
Code Review
gerrit at ovirt.org
Tue Nov 8 12:34:27 UTC 2016
>From Shlomo Ben David <sbendavi at redhat.com>:
Shlomo Ben David has submitted this change and it was merged.
Change subject: Fix 'NoneType' in is_draft argument
......................................................................
Fix 'NoneType' in is_draft argument
When merging patches they are with MERGED status, and the is_draft
argument is set to None instead of 'true' or 'false' strings so it fails on
capitalize.
Change-Id: I54b80db84bebb013d82d6f34ed37da7e15b14e48
FIXES: OVIRT-814
Signed-off-by: Shlomi Ben-David <sbendavi at redhat.com>
---
M hooks/custom_hooks/set_modified
M hooks/custom_hooks/update_tracker
2 files changed, 22 insertions(+), 21 deletions(-)
Approvals:
Shlomo Ben David: Verified; Looks good to me, approved
Pavel Zhukov: Looks good to me, but someone else must approve
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/66182
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I54b80db84bebb013d82d6f34ed37da7e15b14e48
Gerrit-PatchSet: 3
Gerrit-Project: gerrit-admin
Gerrit-Branch: master
Gerrit-Owner: Shlomo Ben David <sbendavi at redhat.com>
Gerrit-Reviewer: Anton Marchukov <amarchuk at redhat.com>
Gerrit-Reviewer: Barak Korren <bkorren at redhat.com>
Gerrit-Reviewer: Eyal Edri <eedri at redhat.com>
Gerrit-Reviewer: Gil Shinar <gshinar at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nadav Goldin <ngoldin at redhat.com>
Gerrit-Reviewer: Pavel Zhukov <pavel at zhukoff.net>
Gerrit-Reviewer: Shlomo Ben David <sbendavi at redhat.com>
More information about the Engine-commits
mailing list