Change in ovirt-engine[master]: core: fix NPE in the initialization of HotSetAmountOfMemory

Code Review gerrit at ovirt.org
Thu Nov 10 06:45:20 UTC 2016


>From Arik Hadas <ahadas at redhat.com>:

Arik Hadas has submitted this change and it was merged.

Change subject: core: fix NPE in the initialization of HotSetAmountOfMemory
......................................................................


core: fix NPE in the initialization of HotSetAmountOfMemory

The initialization of HotSetAmountOfMemoryCommand contains a calculation of
the memory to consume. This requires us to use the VM from the database,
but now VmDao is injected - it will be null in the constructor. Therefore,
moving this initialization to the 'init' method.

Change-Id: I986c095bc20511382a5c41f800a5769eb4c0103d
Bug-Url: https://bugzilla.redhat.com/1391155
Signed-off-by: Arik Hadas <ahadas at redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/HotSetAmountOfMemoryCommand.java
1 file changed, 5 insertions(+), 0 deletions(-)

Approvals:
  Shahar Havivi: Looks good to me, approved
  Jenkins CI: Passed CI tests
  Shmuel Leib Melamud: Looks good to me, but someone else must approve
  Arik Hadas: Verified



-- 
To view, visit https://gerrit.ovirt.org/66352
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I986c095bc20511382a5c41f800a5769eb4c0103d
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Arik Hadas <ahadas at redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Shahar Havivi <shavivi at redhat.com>
Gerrit-Reviewer: Shmuel Leib Melamud <smelamud at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>



More information about the Engine-commits mailing list