Change in ovirt-engine[master]: core: GetVdsAndNetworkInterfacesByNetworkIdQuery accessors

Code Review gerrit at ovirt.org
Thu Nov 10 20:37:08 UTC 2016


>From Allon Mureinik <amureini at redhat.com>:

Allon Mureinik has submitted this change and it was merged.

Change subject: core: GetVdsAndNetworkInterfacesByNetworkIdQuery accessors
......................................................................


core: GetVdsAndNetworkInterfacesByNetworkIdQuery accessors

Removed redundant accessors to external resources (such as DAOs), and
standardized the test accordingly.

Change-Id: Ib0dde222b610b44c14c6bfbf906118f3b44f93fe
Signed-off-by: Allon Mureinik <amureini at redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/GetVdsAndNetworkInterfacesByNetworkIdQuery.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/network/host/GetVdsAndNetworkInterfacesByNetworkIdQueryTest.java
2 files changed, 4 insertions(+), 35 deletions(-)

Approvals:
  Tal Nisan: Looks good to me, approved
  Martin Mucha: Looks good to me, but someone else must approve
  Allon Mureinik: Verified; Passed CI tests

Objections:
  Jenkins CI: Failed CI tests



-- 
To view, visit https://gerrit.ovirt.org/66380
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ib0dde222b610b44c14c6bfbf906118f3b44f93fe
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Mucha <mmucha at redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>



More information about the Engine-commits mailing list