Change in ovirt-engine[master]: webadmin: Fix TypeError

Code Review gerrit at ovirt.org
Sun Nov 13 23:19:02 UTC 2016


>From Moti Asayag <masayag at redhat.com>:

Moti Asayag has submitted this change and it was merged.

Change subject: webadmin: Fix TypeError
......................................................................


webadmin: Fix TypeError

NetworkHostListModel.initAttachedInterfaces() assumes implicitly that
getEntity() is not null. Since other methods of NetworkHostListModel
are implemented without this assumption,
NetworkHostListModel.initAttachedInterfaces() is extended by a suitable
check.

Change-Id: I57332066ef3dd3ff9544e5f296af9b459bbb7b3c
Bug-Url: https://bugzilla.redhat.com/1373937
Signed-off-by: Dominik Holler <dholler at redhat.com>
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/networks/NetworkHostListModel.java
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Dominik Holler: Verified
  Jenkins CI: Passed CI tests
  Moti Asayag: Looks good to me, approved
  Yevgeny Zaspitsky: Looks good to me, but someone else must approve



-- 
To view, visit https://gerrit.ovirt.org/66476
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I57332066ef3dd3ff9544e5f296af9b459bbb7b3c
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Dominik Holler <dholler at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Dominik Holler <dholler at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Marcin Mirecki <mmirecki at redhat.com>
Gerrit-Reviewer: Martin Mucha <mmucha at redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag at redhat.com>
Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>



More information about the Engine-commits mailing list