Change in ovirt-engine[master]: core: rm ConfigureConsoleOptionsQuery#getConfig
Code Review
gerrit at ovirt.org
Wed Nov 16 20:36:10 UTC 2016
>From Allon Mureinik <amureini at redhat.com>:
Allon Mureinik has submitted this change and it was merged.
Change subject: core: rm ConfigureConsoleOptionsQuery#getConfig
......................................................................
core: rm ConfigureConsoleOptionsQuery#getConfig
Inline the useless getConfig method and use the standard MockConfigRule
supplied by the AbstractQueryTest#mcr member to mock config values where
needed.
Note that MockConfigRules mocks the default values for any ConfigValues
that is not supplied, so a lot of the boiler-plate mockings were just
removed for brevity's sake (see commits 9395f and 5b3463 for details).
Change-Id: If94b03439405a9154b120784a1256ad934e9f477
Signed-off-by: Allon Mureinik <amureini at redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ConfigureConsoleOptionsQuery.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/ConfigureConsoleOptionsQueryTest.java
2 files changed, 15 insertions(+), 27 deletions(-)
Approvals:
Tal Nisan: Looks good to me, approved
Allon Mureinik: Verified; Passed CI tests
Objections:
Jenkins CI: Failed CI tests
--
To view, visit https://gerrit.ovirt.org/66937
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: If94b03439405a9154b120784a1256ad934e9f477
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Betak <mbetak at redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
More information about the Engine-commits
mailing list