Change in ovirt-engine[master]: core: Rename upload commands and variables to "transfer"

Code Review gerrit at ovirt.org
Thu Nov 17 17:59:32 UTC 2016


>From Allon Mureinik <amureini at redhat.com>:

Allon Mureinik has submitted this change and it was merged.

Change subject: core: Rename upload commands and variables to "transfer"
......................................................................


core: Rename upload commands and variables to "transfer"

Since the current image upload commands are really about managing the
image transfer, and not specifically "uploading", its name should
reflect that. This can be acheived by renaming the command to
"transfer" commands, E.g:

UploadDiskImageCommand -> TransferDiskImageCommand

This will also allow the addition of the "direction" attribute for a
transfer, which states whether the transfer is an upload or a download,
supporting a download functionallity.

Change-Id: I398e487829d3773a4dd507c9fead4d130c6e798e
Bug-Url: https://bugzilla.redhat.com/1314387
Signed-off-by: Amit Aviram <aaviram at redhat.com>
---
R backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/image/TransferDiskImageCommand.java
R backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/image/TransferImageCommand.java
R backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/image/TransferImageCommandCallback.java
R backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/image/TransferImageStatusCommand.java
R backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/disk/image/TransferDiskImageCommandTest.java
A backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/disk/image/TransferImageCommandTest.java
D backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/disk/image/UploadImageCommandTest.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/AuditLogType.java
R backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/TransferDiskImageParameters.java
R backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/TransferImageParameters.java
A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/TransferImageStatusParameters.java
D backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/UploadImageStatusParameters.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/VdcActionType.java
M backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendImageTransferResource.java
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendImageTransfersResource.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/UploadImageModel.java
17 files changed, 369 insertions(+), 368 deletions(-)

Approvals:
  Allon Mureinik: Looks good to me, approved; Passed CI tests
  Amit Aviram: Verified



-- 
To view, visit https://gerrit.ovirt.org/66337
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I398e487829d3773a4dd507c9fead4d130c6e798e
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Amit Aviram <aaviram at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Amit Aviram <aaviram at redhat.com>
Gerrit-Reviewer: Daniel Erez <derez at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>



More information about the Engine-commits mailing list