Change in ovirt-engine[master]: core: Move/Copy disk flow - weight infra and usage

[Code Review]

>From Liron Aravot <laravot at redhat.com>:

Liron Aravot has submitted this change and it was merged.

Change subject: core: Move/Copy disk flow - weight infra and usage
......................................................................


core: Move/Copy disk flow - weight infra and usage

When command is executed and defines a Job, its initial job weight
is 100. If that command is executing child commands, it can split
the job weight between them to represent the part of each command
in the job.

This patch adds the infra to calculate and pass the weight
of executed child commands and makes use of that infra in the
move/copy disk SDM flow.

In order to avoid handling double values, we use integer for
the weight of each commands - CommandsWeightsHelper.adjust()
can be used in order to round and split the weight of the child
commands according to the provided total weight.

Change-Id: I5414609a17fd06dbc73591487e34619316e71ddb
Signed-off-by: Liron Aravot <laravot at redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/MoveOrCopyDiskCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/image/CloneImageGroupVolumesStructureCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/image/CopyDataCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/image/CopyImageGroupCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/image/CopyImageGroupVolumesDataCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/image/CopyImageGroupWithDataCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/image/CreateVolumeContainerCommand.java
A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/utils/CommandsWeightsUtils.java
A backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/CommandsWeightsUtilsTest.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/ImagesActionsParametersBase.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/VdcActionParametersBase.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/job/Job.java
12 files changed, 233 insertions(+), 17 deletions(-)

Approvals:
  Jenkins CI: Passed CI tests
  Liron Aravot: Verified; Looks good to me, approved



-- 
To view, visit https://gerrit.ovirt.org/66126
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I5414609a17fd06dbc73591487e34619316e71ddb
Gerrit-PatchSet: 27
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Liron Aravot <laravot at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Daniel Erez <derez at redhat.com>
Gerrit-Reviewer: Freddy Rolland <frolland at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Liron Aravot <laravot at redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk at redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag at redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>