Change in ovirt-hosted-engine-setup[master]: upgrade: fixing engine backup location if not /root

Code Review gerrit at ovirt.org
Mon Nov 28 10:49:38 UTC 2016


>From Simone Tiraboschi <stirabos at redhat.com>:

Simone Tiraboschi has submitted this change and it was merged.

Change subject: upgrade: fixing engine backup location if not /root
......................................................................


upgrade: fixing engine backup location if not /root

On upgrades, the engine backup file is always injected
under /root on the appliance.
Fixing if the user keeps on different location on the host.
Using otopi's resolveFile to make it safe against
relative paths.
Making the destination path user configurable.

Change-Id: I864154043a545b8f4c3fa069c9ddfaef19280b34
Bug-Url: https://bugzilla.redhat.com/1394740
Bug-Url: https://bugzilla.redhat.com/1396193
Signed-off-by: Simone Tiraboschi <stirabos at redhat.com>
---
M src/ovirt_hosted_engine_setup/constants.py
M src/plugins/gr-he-common/vm/boot_disk.py
M src/plugins/gr-he-common/vm/cloud_init.py
M src/plugins/gr-he-upgradeappliance/vm/configurevm.py
4 files changed, 16 insertions(+), 3 deletions(-)

Approvals:
  Sandro Bonazzola: Looks good to me, but someone else must approve
  Sefi Litmanovich: Looks good to me, but someone else must approve
  Simone Tiraboschi: Verified; Looks good to me, approved
  Jenkins CI: Passed CI tests



-- 
To view, visit https://gerrit.ovirt.org/67126
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I864154043a545b8f4c3fa069c9ddfaef19280b34
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-hosted-engine-setup
Gerrit-Branch: master
Gerrit-Owner: Simone Tiraboschi <stirabos at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Rafael Martins <rmartins at redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo at redhat.com>
Gerrit-Reviewer: Sefi Litmanovich <slitmano at redhat.com>
Gerrit-Reviewer: Simone Tiraboschi <stirabos at redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <didi at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>



More information about the Engine-commits mailing list