Change in ovirt-engine[master]: webadmin: fix Setup Networks tooltips
Code Review
gerrit at ovirt.org
Tue Nov 29 16:51:24 UTC 2016
>From Greg Sheremeta <gshereme at redhat.com>:
Greg Sheremeta has submitted this change and it was merged.
Change subject: webadmin: fix Setup Networks tooltips
......................................................................
webadmin: fix Setup Networks tooltips
The tooltips in the Setup Networks Dialog were rendering
HTML. Fixed by calling SafeHtmlUtils.fromTrustedString(),
and calling setHTML() on the tooltip instead of setText().
Change-Id: I36f99f9294d32e29c5f0bed810da0297f7153689
Bug-Url: https://bugzilla.redhat.com/1396915
Signed-off-by: Greg Sheremeta <gshereme at redhat.com>
---
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/tooltip/WidgetTooltip.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/panels/ItemInfoPopup.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/panels/NetworkItemPanel.java
3 files changed, 10 insertions(+), 5 deletions(-)
Approvals:
Greg Sheremeta: Verified; Passed CI tests
Vojtech Szocs: Looks good to me, approved
Objections:
Jenkins CI: Failed CI tests
--
To view, visit https://gerrit.ovirt.org/67150
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I36f99f9294d32e29c5f0bed810da0297f7153689
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Greg Sheremeta <gshereme at redhat.com>
Gerrit-Reviewer: Alexander Wels <awels at redhat.com>
Gerrit-Reviewer: Greg Sheremeta <gshereme at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Oved Ourfali <oourfali at redhat.com>
Gerrit-Reviewer: Scott Dickerson <sdickers at redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vszocs at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
More information about the Engine-commits
mailing list