Change in ovirt-engine[master]: core: RefreshGlusterHooksCommandTest @Spy

amureini at redhat.com amureini at redhat.com
Sat Oct 1 19:37:14 UTC 2016


Allon Mureinik has submitted this change and it was merged.

Change subject: core: RefreshGlusterHooksCommandTest @Spy
......................................................................


core: RefreshGlusterHooksCommandTest @Spy

Clean up RefreshGlusterHooksCommandTest to use the @Spy annotation to
spy the command under test in order to facilitate injecting dependencies
to the command in subsequent patches.

- Changing the command being tested to be initialized once and
  annotated with @Spy and @InjectMocks.
- Thus, there is only only command object per test, so all the
  methods receiving commands as parameters were redone to use the
  member.

Change-Id: Ic761866ad707894d27a84b4a53fba16067722e0f
Signed-off-by: Allon Mureinik <amureini at redhat.com>
---
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/gluster/RefreshGlusterHooksCommandTest.java
1 file changed, 7 insertions(+), 7 deletions(-)

Approvals:
  Allon Mureinik: Verified; Looks good to me, approved; Passed CI tests



-- 
To view, visit https://gerrit.ovirt.org/64616
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ic761866ad707894d27a84b4a53fba16067722e0f
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Sahina Bose <sabose at redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>



More information about the Engine-commits mailing list