Change in ovirt-engine[master]: core: UpdateStorageServerConnectionCommandTest collections

amureini at redhat.com amureini at redhat.com
Thu Oct 13 20:50:19 UTC 2016


Allon Mureinik has submitted this change and it was merged.

Change subject: core: UpdateStorageServerConnectionCommandTest collections
......................................................................


core: UpdateStorageServerConnectionCommandTest collections

Use the specialized Arrays.asList, Collections.singletonList and
Collections.emptyList instead of the general purpose ArrayList to
improve the code's readability and gain an (ever so slight) performance
boost.

Change-Id: I82665768a7a8420c4ee4c57d89aa8325f60d07c5
Signed-off-by: Allon Mureinik <amureini at redhat.com>
---
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/connection/UpdateStorageServerConnectionCommandTest.java
1 file changed, 14 insertions(+), 34 deletions(-)

Approvals:
  Tal Nisan: Looks good to me, approved
  Allon Mureinik: Verified; Passed CI tests



-- 
To view, visit https://gerrit.ovirt.org/64710
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I82665768a7a8420c4ee4c57d89aa8325f60d07c5
Gerrit-PatchSet: 11
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Daniel Erez <derez at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>



More information about the Engine-commits mailing list