Change in ovirt-engine[master]: core: StorageHandlingCommandBase#getAllRunningVdssInPool

amureini at redhat.com amureini at redhat.com
Thu Oct 13 20:50:19 UTC 2016


Allon Mureinik has submitted this change and it was merged.

Change subject: core: StorageHandlingCommandBase#getAllRunningVdssInPool
......................................................................


core: StorageHandlingCommandBase#getAllRunningVdssInPool

This method was only used by the StoragePoolStatusHandler.
This patch moves the method to the class that uses it in order to
decouple a false dependency between it and the command.

Change-Id: I3f07248baf52f0096ac450108600a20801196519
Signed-off-by: Allon Mureinik <amureini at redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/StorageHandlingCommandBase.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/pool/StoragePoolStatusHandler.java
2 files changed, 8 insertions(+), 7 deletions(-)

Approvals:
  Tal Nisan: Looks good to me, approved
  Allon Mureinik: Verified; Passed CI tests
  Freddy Rolland: Looks good to me, but someone else must approve



-- 
To view, visit https://gerrit.ovirt.org/64691
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I3f07248baf52f0096ac450108600a20801196519
Gerrit-PatchSet: 11
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Ala Hino <ahino at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Amit Aviram <aaviram at redhat.com>
Gerrit-Reviewer: Freddy Rolland <frolland at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Liron Aravot <laravot at redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>



More information about the Engine-commits mailing list