Change in ovirt-engine[master]: core: ImportVMFromConfigurationCommandTest command initializ...

amureini at redhat.com amureini at redhat.com
Thu Oct 13 20:50:20 UTC 2016


Allon Mureinik has submitted this change and it was merged.

Change subject: core: ImportVMFromConfigurationCommandTest command initialization
......................................................................


core: ImportVMFromConfigurationCommandTest command initialization

Moved the initialization of the tested command to the @Before method
in preparation of moving it to be initialized by a @Spy annotation.

Note that the SimpleDependencyInjector is used to initialize the
command's data members so it must be mocked before the command instance
is created. Hence, this patch moves its handling to a @BeforeClass
method in order to be on the safe side.

Change-Id: I2cc73afe0167d1618e5ff76fae1db2d3a3c563b7
Signed-off-by: Allon Mureinik <amureini at redhat.com>
---
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/exportimport/ImportVMFromConfigurationCommandTest.java
1 file changed, 21 insertions(+), 26 deletions(-)

Approvals:
  Tal Nisan: Looks good to me, approved
  Allon Mureinik: Verified; Passed CI tests



-- 
To view, visit https://gerrit.ovirt.org/64669
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I2cc73afe0167d1618e5ff76fae1db2d3a3c563b7
Gerrit-PatchSet: 11
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Betak <mbetak at redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>



More information about the Engine-commits mailing list