Change in ovirt-engine[master]: core: BaseImagesCommand init SP id

[amureini at redhat.com]

Allon Mureinik has submitted this change and it was merged.

Change subject: core: BaseImagesCommand init SP id
......................................................................


core: BaseImagesCommand init SP id

As all of the image commands happen in the scope of a single storage
pool, it makes sense to allow setting its ID directly on the parameter
object instead of querying it from the passed disk object.

Besides a slight performance improvement, this change also allows
cleaning up some testing flows by allowing us to forgo some stubbing of
these commands.

Change-Id: I4bddbcc64fcaecff1aaf172575a53d430b6caf5f
Signed-off-by: Allon Mureinik <amureini at redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/image/BaseImagesCommand.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/disk/MoveOrCopyDiskCommandTest.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/disk/image/RemoveImageCommandTest.java
3 files changed, 5 insertions(+), 17 deletions(-)

Approvals:
  Tal Nisan: Looks good to me, approved
  Allon Mureinik: Verified; Passed CI tests
  Freddy Rolland: Looks good to me, but someone else must approve



-- 
To view, visit https://gerrit.ovirt.org/64689
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I4bddbcc64fcaecff1aaf172575a53d430b6caf5f
Gerrit-PatchSet: 11
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Amit Aviram <aaviram at redhat.com>
Gerrit-Reviewer: Freddy Rolland <frolland at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Liron Aravot <laravot at redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>