Change in ovirt-engine[master]: core: ImportVMFromConfigurationCommandTest @Spy annotation

[amureini at redhat.com]

Allon Mureinik has submitted this change and it was merged.

Change subject: core: ImportVMFromConfigurationCommandTest @Spy annotation
......................................................................


core: ImportVMFromConfigurationCommandTest @Spy annotation

Spy the command with the @Spy annotation instead of explicitly calling
Mockito.spy. This change has two advantages - first, it's a tad more
elegant, as it saves the duplicate Mockito.spy calls. Second, and more
importantly, it allows injecting the mocked ExternalVmMacsFinder,
MacPoolPerCluster and VmDeviceUtils without an additional boilerplate
code.

Change-Id: Ica69b0e1ce385e7c0ee0b7bdd758edcf94e4fe4b
Signed-off-by: Allon Mureinik <amureini at redhat.com>
---
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/exportimport/ImportVMFromConfigurationCommandTest.java
1 file changed, 8 insertions(+), 22 deletions(-)

Approvals:
  Tal Nisan: Looks good to me, approved
  Allon Mureinik: Verified; Passed CI tests



-- 
To view, visit https://gerrit.ovirt.org/64672
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ica69b0e1ce385e7c0ee0b7bdd758edcf94e4fe4b
Gerrit-PatchSet: 11
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Betak <mbetak at redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>