Change in ovirt-engine[master]: core: AddVmCommandTest - remove stubbing

amureini at redhat.com amureini at redhat.com
Thu Oct 13 20:50:24 UTC 2016


Allon Mureinik has submitted this change and it was merged.

Change subject: core: AddVmCommandTest - remove stubbing
......................................................................


core: AddVmCommandTest - remove stubbing

Remove stubbing a command where it's completely redundant, and replaced
it with standard spying where it wasn't in order to create shorter,
cleaner, easier to understand code.

Change-Id: I74f4e102b4c6eb7386059ba09665c2e2192a3b4e
Signed-off-by: Allon Mureinik <amureini at redhat.com>
---
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/AddVmCommandTest.java
1 file changed, 10 insertions(+), 65 deletions(-)

Approvals:
  Tal Nisan: Looks good to me, approved
  Martin Betak: Looks good to me, but someone else must approve
  Allon Mureinik: Verified; Passed CI tests



-- 
To view, visit https://gerrit.ovirt.org/64642
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I74f4e102b4c6eb7386059ba09665c2e2192a3b4e
Gerrit-PatchSet: 10
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Betak <mbetak at redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>



More information about the Engine-commits mailing list