Change in ovirt-engine[master]: core: UpdateVmCommandTest single command instance

[tnisan at redhat.com]

Tal Nisan has submitted this change and it was merged.

Change subject: core: UpdateVmCommandTest single command instance
......................................................................


core: UpdateVmCommandTest single command instance

Rework the test to use a single command instance, annotated with @Spy
and @InjectMocks in order to reduce code duplication and allow easier
injections.

Note that the OsRepository is used to initialize a data member in
VmCommand, so it must be mocked in a static context, before the
command instance is created.

Change-Id: Id91070d1cde2ea8a5d4a8b00ec49d57237786fbb
Signed-off-by: Allon Mureinik <amureini at redhat.com>
---
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/UpdateVmCommandTest.java
1 file changed, 31 insertions(+), 18 deletions(-)

Approvals:
  Tal Nisan: Looks good to me, approved
  Jenkins CI: Passed CI tests
  Allon Mureinik: Verified



-- 
To view, visit https://gerrit.ovirt.org/64650
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Id91070d1cde2ea8a5d4a8b00ec49d57237786fbb
Gerrit-PatchSet: 12
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Betak <mbetak at redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>