Change in ovirt-engine[master]: core: UpdateStoragePoolCommandTest @Spy annotation

tnisan at redhat.com tnisan at redhat.com
Wed Oct 19 22:47:13 UTC 2016


Tal Nisan has submitted this change and it was merged.

Change subject: core: UpdateStoragePoolCommandTest @Spy annotation
......................................................................


core: UpdateStoragePoolCommandTest @Spy annotation

Spy the command with the @Spy annotation instead of explicitly calling
Mockito.spy in order to use injected mocks instead of explicitly
spying their return.

Change-Id: I904c5db63b6755088010312d699e3d065fd344cf
Signed-off-by: Allon Mureinik <amureini at redhat.com>
---
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/pool/UpdateStoragePoolCommandTest.java
1 file changed, 26 insertions(+), 84 deletions(-)

Approvals:
  Tal Nisan: Looks good to me, approved; Passed CI tests
  Allon Mureinik: Verified

Objections:
  Jenkins CI: Failed CI tests



-- 
To view, visit https://gerrit.ovirt.org/64761
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I904c5db63b6755088010312d699e3d065fd344cf
Gerrit-PatchSet: 15
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Maor Lipchuk <mlipchuk at redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>



More information about the Engine-commits mailing list