Change in ovirt-engine[master]: core: ProcessOvfUpdateForStoragePoolCommandTest @Spy annotation

tnisan at redhat.com tnisan at redhat.com
Wed Oct 19 22:47:14 UTC 2016


Tal Nisan has submitted this change and it was merged.

Change subject: core: ProcessOvfUpdateForStoragePoolCommandTest @Spy annotation
......................................................................


core: ProcessOvfUpdateForStoragePoolCommandTest @Spy annotation

Spy the command with the @Spy annotation instead of explicitly calling
Mockito.spy in order to set the ground for using injected mocks in
these tests in the future.

Note that the command initializes its vmDeviceUtils directly as a data
members with an  Injector, so it must be mocked before the command is
created - i.e., in a @BeforeClass method in a static context.

Change-Id: I6942c896568322f95e2283bbf41f71c2ee67b044
Signed-off-by: Allon Mureinik <amureini at redhat.com>
---
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/ovfstore/ProcessOvfUpdateForStoragePoolCommandTest.java
1 file changed, 6 insertions(+), 1 deletion(-)

Approvals:
  Tal Nisan: Looks good to me, approved
  Jenkins CI: Passed CI tests
  Allon Mureinik: Verified



-- 
To view, visit https://gerrit.ovirt.org/64754
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I6942c896568322f95e2283bbf41f71c2ee67b044
Gerrit-PatchSet: 15
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Liron Aravot <laravot at redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk at redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>



More information about the Engine-commits mailing list