Change in ovirt-engine[master]: core: ManageGlusterServiceCommandTest: separate tests

tnisan at redhat.com tnisan at redhat.com
Mon Oct 24 20:09:35 UTC 2016


Tal Nisan has submitted this change and it was merged.

Change subject: core: ManageGlusterServiceCommandTest: separate tests
......................................................................


core: ManageGlusterServiceCommandTest: separate tests

Separate validateSucceedsWithValidActionTypes() to several test
methods, one per test case, as per JUnit's best practices.

Change-Id: Ifd82bf4ef2be3cbd07822756b4d3196ad57dbf9b
Signed-off-by: Allon Mureinik <amureini at redhat.com>
---
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/gluster/ManageGlusterServiceCommandTest.java
1 file changed, 16 insertions(+), 6 deletions(-)

Approvals:
  Tal Nisan: Looks good to me, approved
  Jenkins CI: Passed CI tests
  Allon Mureinik: Verified



-- 
To view, visit https://gerrit.ovirt.org/65193
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ifd82bf4ef2be3cbd07822756b4d3196ad57dbf9b
Gerrit-PatchSet: 7
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Sahina Bose <sabose at redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>



More information about the Engine-commits mailing list