Change in ovirt-engine[master]: core: simplify fullList on json-rpc at the expense of xml-rpc

masayag at redhat.com masayag at redhat.com
Wed Oct 26 11:28:58 UTC 2016


Moti Asayag has submitted this change and it was merged.

Change subject: core: simplify fullList on json-rpc at the expense of xml-rpc
......................................................................


core: simplify fullList on json-rpc at the expense of xml-rpc

FullListVDSCommand used to convert the given VM IDs to an array because the
XML-RPC based verb expects to get an array. Now that JSON-RPC is the default
and more common protocol, it is time to change this.

So now FullListVDSCommand passes a list that is used as-is with JSON-RPC,
and with XML-RPC it is converted to an array as before.

Change-Id: I3a2e60f2fa2ecbe1b78f588401626d15ed2bb9fc
Signed-off-by: Arik Hadas <ahadas at redhat.com>
---
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/jsonrpc/JsonRpcVdsServer.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/FullListVDSCommand.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/IVdsServer.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsServerWrapper.java
4 files changed, 7 insertions(+), 10 deletions(-)

Approvals:
  Piotr Kliczewski: Looks good to me, but someone else must approve
  Jenkins CI: Passed CI tests
  Moti Asayag: Looks good to me, approved
  Arik Hadas: Verified



-- 
To view, visit https://gerrit.ovirt.org/65332
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I3a2e60f2fa2ecbe1b78f588401626d15ed2bb9fc
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Arik Hadas <ahadas at redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek at redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag at redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali at redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Yaniv Kaul <ykaul at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>



More information about the Engine-commits mailing list