Change in ovirt-engine[master]: webadmin: refactoring of AddRemoveRowWidget, split overgrown...

mbetak at redhat.com mbetak at redhat.com
Wed Oct 26 14:46:55 UTC 2016


Martin Betak has submitted this change and it was merged.

Change subject: webadmin: refactoring of AddRemoveRowWidget, split overgrown method.
......................................................................


webadmin: refactoring of AddRemoveRowWidget, split overgrown
method.

usualy everytime a method accepts boolean flag, this method is
overgrown, worsening maintenance and readability.

Change-Id: I396a048d696ae12773d9ae2b93b17036b8b2b10b
Signed-off-by: Martin Mucha <mmucha at redhat.com>
---
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/AddRemoveRowWidget.java
1 file changed, 52 insertions(+), 34 deletions(-)

Approvals:
  Tomas Jelinek: Looks good to me, approved
  Martin Mucha: Verified
  Jenkins CI: Passed CI tests



-- 
To view, visit https://gerrit.ovirt.org/65570
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I396a048d696ae12773d9ae2b93b17036b8b2b10b
Gerrit-PatchSet: 7
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Martin Mucha <mmucha at redhat.com>
Gerrit-Reviewer: Jakub Niedermertl <jniederm at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Betak <mbetak at redhat.com>
Gerrit-Reviewer: Martin Mucha <mmucha at redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>



More information about the Engine-commits mailing list