Change in ovirt-engine[master]: core: ImageTransferUpdater potential lock leak

amureini at redhat.com amureini at redhat.com
Thu Oct 27 00:48:38 UTC 2016


Allon Mureinik has submitted this change and it was merged.

Change subject: core: ImageTransferUpdater potential lock leak
......................................................................


core: ImageTransferUpdater potential lock leak

This patch releases the lock in a finally block to avoid a lock leak
in case the lock is acquired but the ImageTransfer entity does not
exist.

This patch solves Coverity CID#1361685

Change-Id: Ic8c2e114e46d664368de661c0bd91b1949a0315e
Signed-off-by: Allon Mureinik <amureini at redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/image/ImageTransferUpdater.java
1 file changed, 58 insertions(+), 56 deletions(-)

Approvals:
  Tal Nisan: Looks good to me, approved
  Amit Aviram: Looks good to me, but someone else must approve
  Allon Mureinik: Verified; Passed CI tests



-- 
To view, visit https://gerrit.ovirt.org/65719
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ic8c2e114e46d664368de661c0bd91b1949a0315e
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Amit Aviram <aaviram at redhat.com>
Gerrit-Reviewer: Daniel Erez <derez at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>



More information about the Engine-commits mailing list