Change in ovirt-engine[master]: core: Remove VDS#getCertifaicateSubject

[amureini at redhat.com]

Allon Mureinik has submitted this change and it was merged.

Change subject: core: Remove VDS#getCertifaicateSubject
......................................................................


core: Remove VDS#getCertifaicateSubject

Business entities are shared between the back backend and the
frontend, and as such should be simple data POJO and not contain any
logic.

This patch removes the complicated VDS#getCertificateSubject and changed
the few places that used it to use the CertificateSubjectHelper
directly.

This decouples the VDS[Static] class from the config value and allows
for better layering of the project's logic.

Change-Id: I219df6ed8b40b93645a38b49883b927ac1e9fd2c
Signed-off-by: Allon Mureinik <amureini at redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetVdsCertificateSubjectByVmIdQuery.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VDS.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VdsStatic.java
M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendHostResourceTest.java
M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendHostsResourceTest.java
M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendResourceTest.java
M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/HostMapper.java
7 files changed, 26 insertions(+), 32 deletions(-)

Approvals:
  Tal Nisan: Looks good to me, approved
  Juan Hernandez: Looks good to me, but someone else must approve
  Allon Mureinik: Verified; Passed CI tests



-- 
To view, visit https://gerrit.ovirt.org/65027
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I219df6ed8b40b93645a38b49883b927ac1e9fd2c
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Juan Hernandez <juan.hernandez at redhat.com>
Gerrit-Reviewer: Martin Peřina <mperina at redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>