Change in gerrit-admin[master]: Recreate check_bug_url hook

sbendavi at redhat.com sbendavi at redhat.com
Thu Oct 13 08:29:01 UTC 2016


Shlomo Ben David has submitted this change and it was merged.

Change subject: Recreate check_bug_url hook
......................................................................


Recreate check_bug_url hook

- The new hook is replacing the old
  patchset-created.bz.0.has_bug_url hook and it based on the bz.py module.
- It checks that the bug url exist
- It checks only u/s bug urls (oVirt classification)
- It checks that the bug url is match bugzilla server (bugzilla.redhat.com)
- It checks that the bug id is correct and available

  Example 1:
  classification: oVirt
  bug url: https://other-bugzilla.redhat.com/1234567
  result: WARN, wrong/misspelled bug url

  Example 2:
  classification: other
  bug url: https://bugzilla.redhat.com/1234567
  result: IGNORE, not relevant for 'other' classification

  Example 3:
  classification: oVirt
  bug url: https://bugzilla.redhat.com/1234567890
  result: WARN, unavailable bug id

- All the previous links are pointing to the new hook.

Change-Id: I200131dce12e986fd56cd4faaea5bd6cecb1cb11
Signed-off-by: Shlomi Ben-David <sbendavi at redhat.com>
---
A hooks/custom_hooks/check_bug_url
A hooks/custom_hooks/patchset-created.bz.0.has_bug_url
R hooks/custom_hooks/patchset-created.bz.0.has_bug_url-not-used
D hooks/custom_hooks/patchset-created.bz.0.has_bug_url.sh
4 files changed, 349 insertions(+), 1 deletion(-)

Approvals:
  Shlomo Ben David: Verified; Looks good to me, approved
  Gil Shinar: Looks good to me, but someone else must approve
  Jenkins CI: Passed CI tests



-- 
To view, visit https://gerrit.ovirt.org/65161
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I200131dce12e986fd56cd4faaea5bd6cecb1cb11
Gerrit-PatchSet: 6
Gerrit-Project: gerrit-admin
Gerrit-Branch: master
Gerrit-Owner: Shlomo Ben David <sbendavi at redhat.com>
Gerrit-Reviewer: Anton Marchukov <amarchuk at redhat.com>
Gerrit-Reviewer: Eyal Edri <eedri at redhat.com>
Gerrit-Reviewer: Gil Shinar <gshinar at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Shlomo Ben David <sbendavi at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>



More information about the Engine-commits mailing list