Change in gerrit-admin[master]: Recreate check_target_milestone hook

sbendavi at redhat.com sbendavi at redhat.com
Thu Oct 13 08:29:15 UTC 2016


Shlomo Ben David has submitted this change and it was merged.

Change subject: Recreate check_target_milestone hook
......................................................................


Recreate check_target_milestone hook

- The new hook is replacing the old
  patchset-created.bz.3.correct_target_milestone hook and it based
  on the bz.py module.
- It checks only u/s bugs (oVirt classification)
- It checks that the current patch branch major version is the same
  as the bug target milestone major version.

    Example 1:
    tm: '---'
    branch_maj_version: any
    result: WARN

    Example 2:
    tm_maj_version: 3.6
    branch_maj_version: 3.6
    result: OK

    Example 3:
    tm_maj_version: 3.6
    branch_maj_version: 4.0
    result: checks for clone flags

    Example 4:
    tm_maj_version: 4.0
    branch_maj_version: 3.6
    result: WARN

- All the previous links are pointing to the new hook.

Change-Id: Iefe1ab1fe6c34e6754ed498cfc440691cce88e6e
Fixes: OVIRT-588
Signed-off-by: Shlomi Ben-David <sbendavi at redhat.com>
---
A hooks/custom_hooks/check_target_milestone
A hooks/custom_hooks/patchset-created.bz.3.correct_target_milestone
R hooks/custom_hooks/patchset-created.bz.3.correct_target_milestone-not-used
D hooks/custom_hooks/patchset-created.bz.3.correct_target_milestone.sh
4 files changed, 422 insertions(+), 1 deletion(-)

Approvals:
  Shlomo Ben David: Verified; Looks good to me, approved
  Gil Shinar: Looks good to me, but someone else must approve
  Jenkins CI: Passed CI tests



-- 
To view, visit https://gerrit.ovirt.org/64538
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Iefe1ab1fe6c34e6754ed498cfc440691cce88e6e
Gerrit-PatchSet: 4
Gerrit-Project: gerrit-admin
Gerrit-Branch: master
Gerrit-Owner: Shlomo Ben David <sbendavi at redhat.com>
Gerrit-Reviewer: Anton Marchukov <amarchuk at redhat.com>
Gerrit-Reviewer: Gil Shinar <gshinar at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Shlomo Ben David <sbendavi at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>



More information about the Engine-commits mailing list