Change in gerrit-admin[master]: Fix is_draft (bool) value

sbendavi at redhat.com sbendavi at redhat.com
Mon Oct 31 09:05:34 UTC 2016


Shlomo Ben David has submitted this change and it was merged.

Change subject: Fix is_draft (bool) value
......................................................................


Fix is_draft (bool) value

bool(x) function isn't converts 'True' | 'False' strings into bool
(True | False) values, it only returns True if the passed value is True,
False otherwise.
I've replaced it with ast.literal_eval() function that converts
and returns the required bool values.

Change-Id: I6c17f14465fa9c4cc741f136abc3836ffeaea932
Fixes: OVIRT-797
Signed-off-by: Shlomi Ben-David <sbendavi at redhat.com>
---
M hooks/custom_hooks/update_tracker
1 file changed, 2 insertions(+), 1 deletion(-)

Approvals:
  Shlomo Ben David: Verified; Looks good to me, approved
  Gil Shinar: Looks good to me, but someone else must approve
  Jenkins CI: Passed CI tests



-- 
To view, visit https://gerrit.ovirt.org/65876
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I6c17f14465fa9c4cc741f136abc3836ffeaea932
Gerrit-PatchSet: 1
Gerrit-Project: gerrit-admin
Gerrit-Branch: master
Gerrit-Owner: Shlomo Ben David <sbendavi at redhat.com>
Gerrit-Reviewer: Eyal Edri <eedri at redhat.com>
Gerrit-Reviewer: Gil Shinar <gshinar at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Shlomo Ben David <sbendavi at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>



More information about the Engine-commits mailing list