Change in ovirt-engine-sdk-ruby[sdk_4.0]: Accept 'action' and 'fault' from actions

juan.hernandez at redhat.com juan.hernandez at redhat.com
Thu Sep 1 10:51:41 UTC 2016


Juan Hernandez has submitted this change and it was merged.

Change subject: Accept 'action' and 'fault' from actions
......................................................................


Accept 'action' and 'fault' from actions

Currently the SDK expects that the server to return 'action' XML
elements when actions succeed, and 'fault' when they fail. But the
server may send 'action' with a nested 'fault' when something fails.
This patch modifies the SDK so that it also accepts that.

Change-Id: I9fd210df7aff836421d5c9c3c13652fbd9f390e1
Signed-off-by: Juan Hernandez <juan.hernandez at redhat.com>
(cherry picked from commit 65a779295c65065749177a9243d1155191d958ee)
---
M generator/src/main/java/org/ovirt/sdk/ruby/ServicesGenerator.java
M sdk/lib/ovirtsdk4/service.rb
M sdk/spec/service_spec.rb
M sdk/spec/vm_service_spec.rb
4 files changed, 82 insertions(+), 21 deletions(-)

Approvals:
  Juan Hernandez: Verified; Looks good to me, approved
  Jenkins CI: Passed CI tests



-- 
To view, visit https://gerrit.ovirt.org/63135
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I9fd210df7aff836421d5c9c3c13652fbd9f390e1
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine-sdk-ruby
Gerrit-Branch: sdk_4.0
Gerrit-Owner: Juan Hernandez <juan.hernandez at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Juan Hernandez <juan.hernandez at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>



More information about the Engine-commits mailing list