Change in ovirt-engine[ovirt-engine-4.0]: core: Fix race cond for NextRun and HA VM

tnisan at redhat.com tnisan at redhat.com
Tue Sep 6 15:53:00 UTC 2016


Tal Nisan has submitted this change and it was merged.

Change subject: core: Fix race cond for NextRun and HA VM
......................................................................


core: Fix race cond for NextRun and HA VM

The RunVm command needs to wait on the NextRun
application by ProcessDownVm.

Fixes race condition after cluster version change in
following scenario:
- old cluster, running HA VM
- cluster upgrade, so NextRun config is created
- crash of the HA VM (like kill -9 [qemu_process)]

- AutoStartVmsRunner can't be executed before ProcessDownVm finishes

Change-Id: Ib6ee47d4557badefe9c79106a43b648645177050
Bug-Url: https://bugzilla.redhat.com/1369521
Signed-off-by: Marek Libra <mlibra at redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AutoStartVmsRunner.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/config/ConfigValues.java
M packaging/dbscripts/upgrade/pre_upgrade/0000_config.sql
M packaging/etc/engine-config/engine-config.properties
4 files changed, 61 insertions(+), 1 deletion(-)

Approvals:
  Jenkins CI: Passed CI tests
  Marek Libra: Verified
  Arik Hadas: Looks good to me, approved



-- 
To view, visit https://gerrit.ovirt.org/63436
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ib6ee47d4557badefe9c79106a43b648645177050
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-4.0
Gerrit-Owner: Marek Libra <mlibra at redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Marek Libra <mlibra at redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>



More information about the Engine-commits mailing list