Change in ovirt-engine[master]: core: QuotaManagerTest throws declarations

amureini at redhat.com amureini at redhat.com
Sun Sep 11 20:49:45 UTC 2016


Allon Mureinik has submitted this change and it was merged.

Change subject: core: QuotaManagerTest throws declarations
......................................................................


core: QuotaManagerTest throws declarations

Allow methods to declare a thrown exception (which is never actually
thrown) instead of having to catch it in order to clean up the code.

Besides cleaning up the code, this patch has an added bonus of actually
making the test fail if the underlying implementation is ever broken in
a way that a CloneNotSupportedException is thrown.

Change-Id: Ieddb8c728258be8176b24fb97109dda79e60e47e
Signed-off-by: Allon Mureinik <amureini at redhat.com>
---
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/quota/QuotaManagerTest.java
1 file changed, 10 insertions(+), 16 deletions(-)

Approvals:
  Tal Nisan: Looks good to me, approved
  Martin Peřina: Looks good to me, but someone else must approve
  Allon Mureinik: Verified; Passed CI tests
  Roy Golan: Looks good to me, approved



-- 
To view, visit https://gerrit.ovirt.org/63573
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ieddb8c728258be8176b24fb97109dda79e60e47e
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Peřina <mperina at redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan at redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>



More information about the Engine-commits mailing list