Change in ovirt-engine[master]: core: VersionTest#compare

amureini at redhat.com amureini at redhat.com
Sun Sep 11 20:49:47 UTC 2016


Allon Mureinik has submitted this change and it was merged.

Change subject: core: VersionTest#compare
......................................................................


core: VersionTest#compare

Fix the test to test the CONTRACT of compareTo instead of the specific
implementation.
The implementation can change to return 100 and -100 instead of 1 and -1
and still be completely correct, but fail the older test.

Change-Id: I216941556b1223962a4bb80299435f6d3137289e
Signed-off-by: Allon Mureinik <amureini at redhat.com>
---
M backend/manager/modules/compat/src/test/java/org/ovirt/engine/core/compat/VersionTest.java
1 file changed, 2 insertions(+), 2 deletions(-)

Approvals:
  Martin Peřina: Looks good to me, approved
  Allon Mureinik: Verified; Passed CI tests



-- 
To view, visit https://gerrit.ovirt.org/63569
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I216941556b1223962a4bb80299435f6d3137289e
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Peřina <mperina at redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan at redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>



More information about the Engine-commits mailing list