Change in ovirt-engine-sdk-ruby[sdk_4.0]: Use XML schema naming exceptions

juan.hernandez at redhat.com juan.hernandez at redhat.com
Tue Sep 13 13:58:20 UTC 2016


Juan Hernandez has submitted this change and it was merged.

Change subject: Use XML schema naming exceptions
......................................................................


Use XML schema naming exceptions

Currently the SDK uses incorrect XML tag names for some types, in
particular for the 'OpenStackImageProvider' type. For historical reasons
the tag name corresponding to this type is 'openstack_image_provider',
without a dash between the 'open' and 'stack' words. These naming
exceptions are managed by the 'SchemaNames' class of the metamodel, but
we aren't using it correctly.  This patch fixes that error.

Change-Id: Iedc3d7e7bd542ef3d304530588958d591675d9e0
Signed-off-by: Juan Hernandez <juan.hernandez at redhat.com>
(cherry picked from commit 85fa34b9578b65a15cc1f21a4f0a074819254d9d)
---
M generator/src/main/java/org/ovirt/sdk/ruby/WritersGenerator.java
A sdk/spec/openstack_image_provider_writer_spec.rb
2 files changed, 55 insertions(+), 4 deletions(-)

Approvals:
  Juan Hernandez: Verified; Looks good to me, approved
  Jenkins CI: Passed CI tests



-- 
To view, visit https://gerrit.ovirt.org/63739
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Iedc3d7e7bd542ef3d304530588958d591675d9e0
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine-sdk-ruby
Gerrit-Branch: sdk_4.0
Gerrit-Owner: Juan Hernandez <juan.hernandez at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Juan Hernandez <juan.hernandez at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>



More information about the Engine-commits mailing list